refactor(rbac): drop runtime legacy-format resolution from engine

Roles are stored in the new resource:action format and any legacy keys are
converted once at startup by the RBAC v2 DB migration (migrate_rbac_v2), so
the permission engine no longer needs to resolve legacy codes on every check.

- get_user_permissions: store role permission codes as-is (no dual add).
- has_permission: match new-format codes only; drop resolve_permission and the
  dotted-code fallbacks.
- Remove now-unused resolve_permission import in middleware.
- LEGACY_PERMISSION_MAP / convert_* are retained as one-shot DB-migration
  utilities (upgrade path), not a runtime bridge.
- Tests: adapt fixtures to new-format role permissions; assert legacy keys are
  no longer honored at request time.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
2026-06-20 02:08:19 +05:00
parent de967c35e0
commit d0badd0a2e
5 changed files with 31 additions and 34 deletions

View File

@@ -47,9 +47,15 @@ class TestEngineHasPermission:
assert rbac.PermissionEngine.has_permission(user, "vm:view") is True
assert rbac.PermissionEngine.has_permission(user, "vm:delete") is False
def test_legacy_grant_resolves_to_new(self, rbac, fake_user_factory):
def test_legacy_keys_not_resolved_at_runtime(self, rbac, fake_user_factory):
# Roles are migrated to the new ``resource:action`` format once at
# startup (RBAC v2 DB migration). The engine no longer resolves legacy
# dot-format keys at request time, so a role still holding a legacy key
# grants nothing until it has been migrated.
user = fake_user_factory(permissions={"vms.create": True})
assert rbac.PermissionEngine.has_permission(user, "vm:create") is True
assert rbac.PermissionEngine.has_permission(user, "vm:create") is False
# The migration utility is what bridges the formats, not the engine.
assert rbac.resolve_permission("vms.create") == "vm:create"
def test_wildcard_grants_all_actions_on_resource(self, rbac, fake_user_factory):
user = fake_user_factory(permissions={"vm:*": True})