markmorado/pvemanager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

fix(snapshots): wait for Proxmox task to report real outcome

Browse Source 
create_vm_snapshot/create_container_snapshot returned success as soon as
the POST returned a UPID, so a snapshot that failed asynchronously (e.g.
storage without snapshot support) still reported "created". Now wait on
the task and surface the actual exitstatus.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Dilshod Rasulov
2026-06-20 23:35:26 +05:00
parent a675976303
commit 7d003f7fa1
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
backend/app/proxmox/mixins/snapshot.py
View File

@@ -52,6 +52,11 @@ class SnapshotMixin:
upid = self.proxmox.nodes(node).qemu(vmid).snapshot.post(**params)
logger.info(f"Creating snapshot {snapname} for VM {vmid}")
# Wait for the async Proxmox task so we report the real outcome,
# not just that the task was accepted.
if not self.wait_for_task(node, upid, timeout=300):
reason = self.get_task_status(node, upid).get('exitstatus') or 'task failed or timed out'
return {"success": False, "error": f"Snapshot task failed: {reason}", "upid": upid}
return {"success": True, "upid": upid, "snapname": snapname}
except Exception as e:
logger.error(f"Error creating VM {vmid} snapshot: {e}")
@@ -158,6 +163,11 @@ class SnapshotMixin:
upid = self.proxmox.nodes(node).lxc(vmid).snapshot.post(**params)
logger.info(f"Creating snapshot {snapname} for container {vmid}")
# Wait for the async Proxmox task so we report the real outcome,
# not just that the task was accepted.
if not self.wait_for_task(node, upid, timeout=300):
reason = self.get_task_status(node, upid).get('exitstatus') or 'task failed or timed out'
return {"success": False, "error": f"Snapshot task failed: {reason}", "upid": upid}
return {"success": True, "upid": upid, "snapname": snapname}
except Exception as e:
logger.error(f"Error creating container {vmid} snapshot: {e}")